Add option to not use SmartnoiseSQL #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed yesterday that what I had written in this PR didn't work. I think I fixed it, but this means the tests weren't hitting the new code. I still need to figure out why, and improve the tests. |
Iain-S
reviewed
Apr 25, 2023
Iain-S
approved these changes
Apr 25, 2023
|
|
||
| else: | ||
|
|
||
| def execute_query(conn: Any, stat_data: Dict[str, Any]) -> Any: |
There was a problem hiding this comment.
Do you think we should type the return as List[List] (or Iterable[Iterable]) or similar?
Suggested change
| def execute_query(conn: Any, stat_data: Dict[str, Any]) -> Any: | |
| def execute_query(conn: Any, stat_data: Dict[str, Any]) -> List[List]: |
There was a problem hiding this comment.
The problem is we need to change the type signature of execute_query in both branches of the if statement to keep mypy happy (All conditional function variants must have identical signatures), and mypy doesn't know what the return type of SNSQL's private_reader.execute is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, you can now set a top-level setting in
config.yamlto sayuse-smartnoise-sql: False, and the queries will be run raw, without SNSQL to noise them.I also threw in a couple of unrelated tiny changes because I'm lazy to make one line PRs.
Closes #75